feat: remove pod/service account labeled check in webhook #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
aramase/f/658
branch
from
dad8fc5
to
1b574a1
Compare
aramase
force-pushed
the
aramase/f/658
branch
from
1b574a1
to
340dbf9
Compare
aramase
force-pushed
the
aramase/f/658
branch
from
340dbf9
to
4bdc510
Compare
@aramase what exactly does that mean for the app? |
enj
reviewed
Jan 26, 2023
If the app relies on Either the service account is created simultaneously when the pod is created and we don't see it while mutating or the service account doesn't exist in which case pod will fail with service account not found? |
aramase
force-pushed
the
aramase/f/658
branch
2 times, most recently
from
9cbceb7
to
733d66e
Compare
aramase
force-pushed
the
aramase/f/658
branch
from
733d66e
to
a5d05b6
Compare
With the objectselector set in mwh, only pods that have the label `azure.workload.identity/use: "true"` will be sent to the webhook for mutation. We no longer need the check for pod/service account labeled. Signed-off-by: Anish Ramasekar <[email protected]>
aramase
force-pushed
the
aramase/f/658
branch
from
a5d05b6
to
3bfdef2
Compare
enj
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar [email protected]
Reason for Change:
With the objectselector set in mwh, only pods that have the label
azure.workload.identity/use: "true"will be sent to the webhook for mutation. We no longer need the check for pod/service account labeled.Requirements
Issue Fixed:
fixes #658
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: