Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add readiness and liveness probes to webhook #95

Merged
merged 1 commit into from
Jul 13, 2021
Merged

feat: add readiness and liveness probes to webhook #95

merged 1 commit into from
Jul 13, 2021

Conversation

chewong
Copy link
Contributor

@chewong chewong commented Jul 13, 2021

Signed-off-by: Ernest Wong [email protected]

Reason for Change:

Implement liveness and readiness probe for the webhook.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Fixes #94

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@chewong chewong marked this pull request as ready for review July 13, 2021 21:10
@chewong chewong requested review from aramase and sozercan July 13, 2021 21:10
@chewong chewong merged commit 1f4c734 into Azure:main Jul 13, 2021
@chewong chewong deleted the probe branch July 13, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase approved these changes

@sozercan sozercan Awaiting requested review from sozercan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a readiness probe for the webhook
2 participants
@chewong @aramase