Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user in image config #168

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add user in image config #168

merged 3 commits into from
Feb 29, 2024

Conversation

cpuguy83
Copy link
Member

This allows the spec to override the user in the base image.

Closes #140

This will be useful across all frontends.

Signed-off-by: Brian Goff <[email protected]>
@cpuguy83 cpuguy83 requested a review from a team as a code owner February 27, 2024 20:28
This allows specs to set the target user in an image.

Signed-off-by: Brian Goff <[email protected]>
image.go Outdated Show resolved Hide resolved
I expect to start moving these structs into separate files just to help
organize things better.
Since I'm messing with this now, now seemed like a good time to do this
one.

Signed-off-by: Brian Goff <[email protected]>
Copy link
Contributor

@adamperlin adamperlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@cpuguy83 cpuguy83 merged commit 88e1cac into Azure:main Feb 29, 2024
9 checks passed
@cpuguy83 cpuguy83 deleted the user_in_config branch February 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify user in image config?
2 participants