Implement Package Signing #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmengelbert
requested review from
cpuguy83,
sozercan,
adamperlin and
DannyBrito
pmengelbert
commented
Apr 19, 2024
pmengelbert
force-pushed
the
pmengelbert/package_signing/5
branch
from
1f8d93f
to
4c4edd1
Compare
cpuguy83
requested changes
Apr 19, 2024
pmengelbert
force-pushed
the
pmengelbert/package_signing/5
branch
from
26a3286
to
bca560c
Compare
DannyBrito
reviewed
Apr 30, 2024
DannyBrito
reviewed
Apr 30, 2024
The general idea is that the image specified in spec.targets.x.package_config.signer.image will receive an `llb.State` as an input, and provide a tranformed state (with the artifacts in question signed in the desired manner) as the output. Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
I had been using debugging symbols to fix some issues in the integration tests. Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Instead of telling the frontend how to search for artifacts to sign, only provide `dalec.target` and delegate responsibility for finding the artifacts to the signing side. The target should be sufficient to determine what to do. Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
pmengelbert
force-pushed
the
pmengelbert/package_signing/5
branch
from
72c6130
to
accc429
Compare
cpuguy83
requested changes
Apr 30, 2024
test/fixtures/signer/main.go
Outdated
| signOp = linuxSignOp | ||
| } | ||
|
|
||
| config := Config{ |
There was a problem hiding this comment.
Can we simplify this down to something minimal for the test fixture?
* Move signing tests to mariner2_test and windows_test, respectively, since the test is checking 1) that the forwarding happens and 2) that the signing frontend receives sufficient information to determine signing logic. * Simplify the test signing frontend to do less. Signed-off-by: Peter Engelbert <[email protected]>
This allows the same signer to be configured for all distros in the spec. Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
cpuguy83
requested changes
May 1, 2024
test/mariner2_test.go
Outdated
| }, | ||
| } | ||
|
|
||
| sr := newSolveRequest(withSpec(ctx, t, &spec), withBuildTarget("mariner2/rpm")) |
There was a problem hiding this comment.
This is specific to mariner, but we should treat this as a more generic test so that we can add other distros (azlinux3, jammy, etc) and get these tests for free.
Maybe we need to add an extra parameter to the test function to specify the signing target.
There was a problem hiding this comment.
I made this generic. LMK what you think
Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
cpuguy83
approved these changes
May 1, 2024
This was referenced May 6, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: