Add spec load pass to check for undefined build args #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you happen to look into using https://pkg.go.dev/github.com/moby/buildkit/frontend/dockerfile/shell?utm_source=godoc#Lex.ProcessWordWithMatches instead? |
|
Ah no, I was not aware that function existed. I will see if I can reimplement using that instead |
|
It looks like the version of this function you referenced exists in a newer version of buildkit (0.14.0) than the one we import in dalec (0.13.1). Are we ok to bump the buildkit dependency? |
|
Oh nice, yes we can/should bump it. |
adamperlin
force-pushed
the
adamperlin/fix-undefined-build-arg-subst
branch
from
4ea9b75
to
6a320db
Compare
cpuguy83
requested changes
Jul 11, 2024
cpuguy83
requested changes
Aug 21, 2024
cpuguy83
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, if a build arg is not specified in the
argssection of a Dalec spec file, its value is set to""when the spec is loaded. This is confusing behavior, as a user could easily forget to declare a build-arg or mistype a build-arg reference, leading to an empty string substitution which could be hard to track down.This PR adds an additional pass upon loading the spec which tokenizes all the build args first, and checks to ensure that each referenced arg does appear in the
argssection of the spec, raising an error if not.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #274
Special notes for your reviewer: