Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add prebuild work images #286

Closed

Conversation

DannyBrito
Copy link
Contributor

What this PR does / why we need it:
Initial work to add pre-build images for mariner, azlinux worker images.

Fixes # #177

Questions:

  1. Would these work images need to be versioned? If so, would these follow same versioning of dalec tags?
  2. Would we need to add a ci for these images?

@DannyBrito DannyBrito requested a review from a team as a code owner June 10, 2024 20:45
@pmengelbert
Copy link
Contributor

Can you update the PR description with some detail on what problem this is solving?

Copy link
Contributor

@pmengelbert pmengelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@cpuguy83
Copy link
Member

In #328 we added support for:

  1. Supplying a custom worker image by providing a specifically named build context (name depends on the target)
  2. Building/exporting just the worker image as a build target, e.g. mariner2/worker

With these we have these pre-cached worker images without having to maintain a custom set in the repo (though we still could do this, just using the new build endpoints).

@cpuguy83 cpuguy83 closed this Aug 21, 2024
@DannyBrito DannyBrito deleted the dannybrito/marine-prebuild-image branch August 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants