Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add events for service export #107

Merged
merged 4 commits into from
Sep 2, 2022
Merged

feat: add events for service export #107

merged 4 commits into from
Sep 2, 2022

Conversation

zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Sep 1, 2022 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • add user facing event for service export
  • fix the log level
  • fix message

Requirements:

michaelawyu
michaelawyu approved these changes Sep 2, 2022
View reviewed changes
Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhiying-lin zhiying-lin merged commit 7996864 into Azure:main Sep 2, 2022
@zhiying-lin zhiying-lin deleted the serviceexport-event branch September 2, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelawyu michaelawyu michaelawyu approved these changes

@mainred mainred Awaiting requested review from mainred

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiying-lin @michaelawyu