Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't capitalize error string #127

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

mainred
Copy link
Member

@mainred mainred commented Sep 28, 2022

What type of PR is this?

What this PR does / why we need it:

Error strings should not be capitalized (unless beginning with proper nouns or acronyms) or end with punctuation, since they are usually printed following other context

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #127 (9ed6881) into main (63a876a) will increase coverage by 0.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   78.12%   78.77%   +0.65%     
==========================================
  Files          20       20              
  Lines        2455     2455              
==========================================
+ Hits         1918     1934      +16     
+ Misses        422      409      -13     
+ Partials      115      112       -3     
Impacted Files Coverage Δ
pkg/controllers/multiclusterservice/controller.go 84.24% <0.00%> (+1.09%) ⬆️
pkg/controllers/member/endpointslice/controller.go 80.64% <0.00%> (+2.82%) ⬆️
...rollers/member/internalserviceexport/controller.go 83.33% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mainred mainred merged commit 07d9ba2 into Azure:main Oct 10, 2022
@mainred mainred deleted the lowcase-error-msg branch October 10, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants