Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics (1/) #128

Merged
merged 10 commits into from
Oct 12, 2022
Merged

feat: add metrics (1/) #128

merged 10 commits into from
Oct 12, 2022

Conversation

michaelawyu
Copy link
Collaborator

@michaelawyu michaelawyu commented Sep 28, 2022

What type of PR is this?

/kind test
/kind feature

/kind api-change
/kind flake

What this PR does / why we need it:

This PR is the first part of a series of PRs that add metrics to Fleet networking controllers. As a part of the change, this PR also:

  • adds an ExportedSince field to ExportedObjectReference objects (API change)
  • refactors integration tests for several controllers, most importantly ServiceExport, EndpointSlice, InternalServiceExport, and EndpointSliceImport
  • fixes a number of issues that leads to flaky integration tests

Which issue(s) this PR fixes:

N/A

Requirements:

How has this code been tested

[x] Unit tests
[x] Integration tests

Special notes for your reviewer

This PR only introduces the API change, makes changes to the tests (specifically refactors the integration tests for ServiceExport + EndpointSlice controllers), and applies some metric collection preparation work. The actual metric collection part will be added in the next PR.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #128 (ae67727) into main (e5d0041) will increase coverage by 0.59%.
The diff coverage is 88.34%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   78.39%   78.98%   +0.59%     
==========================================
  Files          20       20              
  Lines        2481     2551      +70     
==========================================
+ Hits         1945     2015      +70     
+ Misses        423      421       -2     
- Partials      113      115       +2     
Impacted Files Coverage Δ
...ntrollers/member/endpointsliceimport/controller.go 76.79% <ø> (+3.31%) ⬆️
...rollers/member/internalserviceexport/controller.go 83.33% <ø> (ø)
pkg/controllers/member/serviceexport/controller.go 77.01% <85.00%> (+1.89%) ⬆️
pkg/controllers/member/endpointslice/controller.go 77.45% <92.50%> (-0.37%) ⬇️
...ntrollers/member/endpointsliceexport/controller.go 83.05% <100.00%> (ø)
pkg/controllers/member/serviceimport/controller.go 69.69% <100.00%> (ø)
...ontrollers/hub/internalserviceimport/controller.go 76.30% <0.00%> (-1.61%) ⬇️
pkg/controllers/multiclusterservice/controller.go 87.07% <0.00%> (+1.02%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@michaelawyu michaelawyu changed the title feat: add metrics [pending a few final checks] feat: add metrics [large PR; will split] Sep 29, 2022
@michaelawyu michaelawyu changed the title feat: add metrics [large PR; will split] feat: add metrics (1/) Sep 29, 2022
pkg/common/objectmeta/objectmeta.go Outdated Show resolved Hide resolved
pkg/common/objectmeta/objectmeta.go Outdated Show resolved Hide resolved
pkg/controllers/member/endpointslice/controller.go Outdated Show resolved Hide resolved
pkg/controllers/member/endpointslice/controller.go Outdated Show resolved Hide resolved
api/v1alpha1/common_types.go Show resolved Hide resolved
@michaelawyu michaelawyu merged commit 54fe6e1 into Azure:main Oct 12, 2022
@michaelawyu michaelawyu deleted the metrics branch October 12, 2022 19:11
@michaelawyu michaelawyu mentioned this pull request Oct 12, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants