-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metrics (1/) #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 78.39% 78.98% +0.59%
==========================================
Files 20 20
Lines 2481 2551 +70
==========================================
+ Hits 1945 2015 +70
+ Misses 423 421 -2
- Partials 113 115 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zhiying-lin
reviewed
Oct 8, 2022
zhiying-lin
reviewed
Oct 11, 2022
zhiying-lin
reviewed
Oct 12, 2022
config/crd/bases/networking.fleet.azure.com_internalserviceexports.yaml
Outdated
Show resolved
Hide resolved
zhiying-lin
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
/kind feature
/kind api-change
/kind flake
What this PR does / why we need it:
This PR is the first part of a series of PRs that add metrics to Fleet networking controllers. As a part of the change, this PR also:
ExportedSince
field toExportedObjectReference
objects (API change)ServiceExport
,EndpointSlice
,InternalServiceExport
, andEndpointSliceImport
Which issue(s) this PR fixes:
N/A
Requirements:
make reviewable
for basic local testHow has this code been tested
[x] Unit tests
[x] Integration tests
Special notes for your reviewer
This PR only introduces the API change, makes changes to the tests (specifically refactors the integration tests for ServiceExport + EndpointSlice controllers), and applies some metric collection preparation work. The actual metric collection part will be added in the next PR.