Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't use hard-coded LOCATION for e2e bootstrap #131

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

mainred
Copy link
Member

@mainred mainred commented Sep 29, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #131 (18e44df) into main (63a876a) will increase coverage by 0.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   78.12%   78.77%   +0.65%     
==========================================
  Files          20       20              
  Lines        2455     2455              
==========================================
+ Hits         1918     1934      +16     
+ Misses        422      406      -16     
  Partials      115      115              
Impacted Files Coverage Δ
...ontrollers/hub/internalserviceexport/controller.go 78.78% <0.00%> (-2.43%) ⬇️
pkg/controllers/multiclusterservice/controller.go 83.15% <0.00%> (ø)
.../controllers/hub/endpointsliceexport/controller.go 73.20% <0.00%> (+3.01%) ⬆️
...ntrollers/member/endpointsliceimport/controller.go 76.79% <0.00%> (+3.31%) ⬆️
...rollers/member/internalserviceexport/controller.go 83.33% <0.00%> (+8.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@zhiying-lin zhiying-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the PR title to test:xxx? others LGTM

@mainred mainred changed the title fix: don't use hard-coded LOCATION for e2e bootstrap test: don't use hard-coded LOCATION for e2e bootstrap Oct 12, 2022
@mainred mainred merged commit a275712 into Azure:main Oct 12, 2022
@mainred mainred deleted the minor-fix branch October 12, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants