fix: sync imc api with fleet repo #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiying-lin
requested review from
michaelawyu,
mainred and
ryanzhang-oss
and removed request for
michaelawyu
michaelawyu
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind api-change
Which issue(s) this PR fixes:
Breaking change was introduced in PR. heartbeatPeriodSeconds was changed from leaseDurationSeconds to heartbeatPeriodSeconds.
heartbeat was treated as 0 right now.
Requirements:
make reviewablefor basic local testHow has this code been tested
Tested in e2e standalone env with the fix.