Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Previously we use Expect inside Eventually to wait for the derived service, which does not honor retry, and fails the test once the derived service is not found. Fix this by raise the error instead of do assertion, which retry fetching derived service when it's not found.
Besides this change, this PR also usesapiretry.Do
to retry APIServer request to avoid false negative test failure.Finally, to make the e2e tests log more readable and less messy, we split the e2e env setup step from e2e test.
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewable
for basic local testHow has this code been tested
Special notes for your reviewer