Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: stabilize e2e test #135

Merged
merged 4 commits into from
Oct 12, 2022
Merged

test: stabilize e2e test #135

merged 4 commits into from
Oct 12, 2022

Conversation

mainred
Copy link
Member

@mainred mainred commented Oct 11, 2022

What type of PR is this?

What this PR does / why we need it:
Previously we use Expect inside Eventually to wait for the derived service, which does not honor retry, and fails the test once the derived service is not found. Fix this by raise the error instead of do assertion, which retry fetching derived service when it's not found.
Besides this change, this PR also uses apiretry.Do to retry APIServer request to avoid false negative test failure.
Finally, to make the e2e tests log more readable and less messy, we split the e2e env setup step from e2e test.

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #135 (acb5e44) into main (e5d0041) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   78.39%   78.55%   +0.16%     
==========================================
  Files          20       20              
  Lines        2481     2481              
==========================================
+ Hits         1945     1949       +4     
+ Misses        423      418       -5     
- Partials      113      114       +1     
Impacted Files Coverage Δ
pkg/controllers/member/endpointslice/controller.go 76.20% <0.00%> (-1.62%) ⬇️
pkg/controllers/multiclusterservice/controller.go 84.69% <0.00%> (-1.37%) ⬇️
...ntrollers/member/endpointsliceimport/controller.go 80.11% <0.00%> (+6.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This reverts commit db765d0f807248cd9e4a544e334c5dd1fbe6cda2.
@mainred mainred merged commit 81760b0 into Azure:main Oct 12, 2022
@mainred mainred deleted the stablize-e2e branch October 12, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants