Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run the test against prod k8s version #137

Merged
merged 3 commits into from
Oct 26, 2022
Merged

test: run the test against prod k8s version #137

merged 3 commits into from
Oct 26, 2022

Conversation

zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Oct 18, 2022

What type of PR is this?
/kind bug
/kind test

What this PR does / why we need it:

Which issue(s) this PR fixes:
We currently run the integration test against the latest k8s API version that controller runtime support. We need to run against the version we will run in production.

original PR

Requirements:

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #137 (05cf67c) into main (aa10bf5) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 05cf67c differs from pull request most recent head 9fc96a6. Consider uploading reports for the commit 9fc96a6 to get more accurate results

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   78.87%   78.75%   -0.12%     
==========================================
  Files          20       20              
  Lines        2551     2551              
==========================================
- Hits         2012     2009       -3     
  Misses        426      426              
- Partials      113      116       +3     
Impacted Files Coverage Δ
...rollers/member/internalserviceexport/controller.go 75.00% <0.00%> (-8.34%) ⬇️
...ontrollers/hub/internalserviceimport/controller.go 74.69% <0.00%> (-3.22%) ⬇️
...ontrollers/hub/internalserviceexport/controller.go 78.78% <0.00%> (-2.43%) ⬇️
pkg/controllers/multiclusterservice/controller.go 86.05% <0.00%> (-1.03%) ⬇️
...ntrollers/member/endpointsliceimport/controller.go 76.79% <0.00%> (ø)
.../controllers/hub/endpointsliceexport/controller.go 70.18% <0.00%> (+2.64%) ⬆️
pkg/controllers/member/endpointslice/controller.go 81.45% <0.00%> (+4.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@zhiying-lin zhiying-lin merged commit a82a289 into Azure:main Oct 26, 2022
@zhiying-lin zhiying-lin deleted the fixed-k8-version branch October 26, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants