Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade golang.org/x/text to fix the vulnerability #138

Merged
merged 8 commits into from
Oct 19, 2022
Merged

fix: upgrade golang.org/x/text to fix the vulnerability #138

merged 8 commits into from
Oct 19, 2022

Conversation

zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Oct 18, 2022

What type of PR is this?
/kind bug
/kind test
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

  • bug: golang.org/x/text CVE-2022-32149
  • test: increase the timeout & backoff steps to wait for the serviceexport condition changes
  • test: use Succeed instead of nil in order to print out diff friendly

Requirements:

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #138 (8f70573) into main (54fe6e1) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   78.08%   77.96%   -0.12%     
==========================================
  Files          20       20              
  Lines        2551     2551              
==========================================
- Hits         1992     1989       -3     
- Misses        440      443       +3     
  Partials      119      119              
Impacted Files Coverage Δ
...rollers/member/internalmembercluster/controller.go 68.87% <0.00%> (-2.65%) ⬇️
pkg/controllers/multiclusterservice/controller.go 82.31% <0.00%> (-2.39%) ⬇️
...ontrollers/hub/internalserviceimport/controller.go 77.91% <0.00%> (+1.60%) ⬆️
...ontrollers/hub/internalserviceexport/controller.go 81.21% <0.00%> (+2.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhiying-lin zhiying-lin changed the title test: increase timeout when polling networking resources fix: upgrade golang.org/x/text to fix the vulnerability Oct 19, 2022
@zhiying-lin zhiying-lin merged commit aa10bf5 into Azure:main Oct 19, 2022
@zhiying-lin zhiying-lin deleted the flaky-test branch October 19, 2022 06:43
@zhiying-lin zhiying-lin changed the title fix: upgrade golang.org/x/text to fix the vulnerability security: upgrade golang.org/x/text to fix the vulnerability Oct 19, 2022
@zhiying-lin zhiying-lin changed the title security: upgrade golang.org/x/text to fix the vulnerability fix: upgrade golang.org/x/text to fix the vulnerability Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants