Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sink notfound errors #139

Merged
merged 1 commit into from
Oct 24, 2022
Merged

fix: sink notfound errors #139

merged 1 commit into from
Oct 24, 2022

Conversation

zhiying-lin
Copy link
Contributor

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:
Change the log level from error to info for notFound error

Which issue(s) this PR fixes:

Requirements:

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #139 (b5273eb) into main (aa10bf5) will decrease coverage by 0.78%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   78.87%   78.08%   -0.79%     
==========================================
  Files          20       20              
  Lines        2551     2587      +36     
==========================================
+ Hits         2012     2020       +8     
- Misses        426      451      +25     
- Partials      113      116       +3     
Impacted Files Coverage Δ
pkg/controllers/member/serviceimport/controller.go 68.11% <57.14%> (-1.59%) ⬇️
.../controllers/hub/endpointsliceexport/controller.go 69.77% <66.66%> (+2.22%) ⬆️
...ontrollers/hub/internalserviceimport/controller.go 75.79% <66.66%> (-2.12%) ⬇️
pkg/controllers/hub/serviceimport/controller.go 72.85% <66.66%> (-0.87%) ⬇️
...ntrollers/member/endpointsliceexport/controller.go 80.64% <66.66%> (-2.41%) ⬇️
...ntrollers/member/endpointsliceimport/controller.go 72.82% <66.66%> (-3.97%) ⬇️
...rollers/member/internalserviceimport/controller.go 75.43% <66.66%> (-2.34%) ⬇️
pkg/controllers/multiclusterservice/controller.go 85.52% <66.66%> (-1.56%) ⬇️
...ontrollers/hub/internalserviceexport/controller.go 77.97% <80.00%> (-3.24%) ⬇️
pkg/controllers/member/endpointslice/controller.go 78.41% <80.00%> (+0.96%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@zhiying-lin zhiying-lin merged commit 67bce8c into Azure:main Oct 24, 2022
@zhiying-lin zhiying-lin deleted the sink-error branch October 24, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants