Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update GitHub Actions workflows #146

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

michaelawyu
Copy link
Collaborator

@michaelawyu michaelawyu commented Dec 1, 2022

What type of PR is this?

/kind bug
/kind test
/kind failing-test

What this PR does / why we need it:

This PR updates the GitHub Actions workflows for the fleet-networking repository, as a number of workflows no longer function after the repository went public. Specifically:

  • Trivy vulnerability scanner are set to run only when a) a PR is merged to the main branch, b) a new release tag is made -> for security reasons, on public repositories, GitHub Actions will not grant write permissions to workflow runs upon new pull requests
  • E2E tests are set to run only when a) a PR is merged to the main branch, b) a new release tag is made, or c) requested explicitly -> for security reasons, on public repositories, GitHub Actions will not pass in secrets to workflow runs upon new pull requests
  • Proxy settings for accessing private Go modules are removed
  • Minor fixes/adjustments

Which issue(s) this PR fixes:

N/A

Requirements:

How has this code been tested

N/A

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #146 (4999b47) into main (96d65ab) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   78.28%   78.31%   +0.03%     
==========================================
  Files          20       20              
  Lines        2712     2712              
==========================================
+ Hits         2123     2124       +1     
+ Misses        468      467       -1     
  Partials      121      121              
Impacted Files Coverage Δ
pkg/controllers/multiclusterservice/controller.go 84.17% <0.00%> (-1.02%) ⬇️
...ontrollers/hub/internalserviceimport/controller.go 77.38% <0.00%> (+1.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhiying-lin zhiying-lin merged commit 1db0d3b into Azure:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants