Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support internal load balancer type #147

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Dec 6, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Manually validated the internal ip of the mcs,
Created the mcs in member-1 and ip is not reachable from outside.
image
Created the debug pod in member-2
image
Sent the curl request from the node
image

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #147 (90d3d2a) into main (1db0d3b) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   79.09%   79.02%   -0.08%     
==========================================
  Files          20       20              
  Lines        2712     2722      +10     
==========================================
+ Hits         2145     2151       +6     
- Misses        450      456       +6     
+ Partials      117      115       -2     
Impacted Files Coverage Δ
pkg/controllers/multiclusterservice/controller.go 89.25% <100.00%> (+5.07%) ⬆️
pkg/controllers/hub/serviceimport/controller.go 72.85% <0.00%> (-4.29%) ⬇️
.../controllers/hub/endpointsliceexport/controller.go 69.77% <0.00%> (-2.99%) ⬇️
...ontrollers/hub/internalserviceexport/controller.go 77.97% <0.00%> (-2.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ryanzhang-oss ryanzhang-oss merged commit 5e3ea49 into Azure:main Dec 7, 2022
@zhiying-lin zhiying-lin deleted the internal-lb-new branch December 7, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants