Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HUB_KUBE_HEADER system environment variable #150

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

mingqishao
Copy link
Contributor

What type of PR is this?
add a new feature: custom the header of hub's http client.

What this PR does / why we need it:
The hub cluster need additional http header for authentication or authorization. This PR to add a new system environment variable "HUB_KUBE_HEADER" to allow sending custom header to hub's API Server

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@mingqishao mingqishao added the enhancement New feature or request label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #150 (dcd32a2) into main (5c58841) will increase coverage by 0.47%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   78.50%   78.97%   +0.47%     
==========================================
  Files          20       21       +1     
  Lines        2735     2759      +24     
==========================================
+ Hits         2147     2179      +32     
+ Misses        468      460       -8     
  Partials      120      120              
Files Changed Coverage Δ
pkg/common/hubconfig/hubconfig.go 78.46% <70.00%> (-1.54%) ⬇️
pkg/common/httpclient/round_tripper.go 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

go.mod Show resolved Hide resolved
Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingqishao mingqishao merged commit ea922fb into main Aug 2, 2023
8 checks passed
@zhiying-lin zhiying-lin deleted the minsha/add-HUB_KUBE_HEADER branch April 25, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants