Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix github action commit-lint #151

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

zhiying-lin
Copy link
Contributor

What type of PR is this?

/kind regression

What this PR does / why we need it:

Which issue(s) this PR fixes:
upgrade the pr-title-checker to fix the 1.3.1 issue

/home/runner/work/_actions/thehanimo/pr-title-checker/v1.3.1/index.js:110
    if (alwaysPassCI) {
^
ReferenceError: alwaysPassCI is not defined
    at removeLabel (/home/runner/work/_actions/thehanimo/pr-title-checker/v1.3.1/index.js:110:1)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Requirements:

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #151 (9ff853f) into main (f901a19) will decrease coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   79.26%   78.90%   -0.37%     
==========================================
  Files          20       20              
  Lines        2735     2735              
==========================================
- Hits         2168     2158      -10     
- Misses        450      460      +10     
  Partials      117      117              

see 4 files with indirect coverage changes

Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiying-lin zhiying-lin merged commit 5c58841 into Azure:main Aug 1, 2023
7 of 8 checks passed
@zhiying-lin zhiying-lin deleted the fix branch August 1, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants