Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for v1beta1 cluster API #157

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

michaelawyu
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for v1beta1 cluster API to the repo.

It also updates the charts + applies other minor changes necessary.

Which issue(s) this PR fixes:

N/A

Requirements:

How has this code been tested

  • Unit tests
  • Integration tests

Special notes for your reviewer

@michaelawyu
Copy link
Collaborator Author

Due to version conflicts, checks for this PR will not pass until the Go version is bumped.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #157 (3cd8b62) into main (248b683) will decrease coverage by 1.44%.
The diff coverage is 63.81%.

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   79.05%   77.61%   -1.44%     
==========================================
  Files          21       22       +1     
  Lines        2759     2899     +140     
==========================================
+ Hits         2181     2250      +69     
- Misses        459      514      +55     
- Partials      119      135      +16     
Files Changed Coverage Δ
...ember/internalmembercluster/v1alpha1/controller.go 68.18% <ø> (ø)
.../controllers/hub/endpointsliceexport/controller.go 69.77% <50.00%> (ø)
...nternalmembercluster/v1beta1/controller_v1beta1.go 65.00% <65.00%> (ø)

... and 6 files with indirect coverage changes

@zhiying-lin zhiying-lin merged commit 5af2b35 into Azure:main Sep 6, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants