feat: add new test CRD to replace kruise API #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an error handling pipeline event 4a302cda-8d57-441d-b73c-30bdcc599603. |
Arvindthiru
commented
Jun 21, 2024
| @@ -233,7 +233,7 @@ CRD_OPTIONS ?= "crd" | |||
| .PHONY: manifests | |||
| manifests: $(CONTROLLER_GEN) | |||
| $(CONTROLLER_GEN) \ | |||
| $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases | |||
| $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./apis/..." output:crd:artifacts:config=config/crd/bases | |||
There was a problem hiding this comment.
This done to ensure we only generate CRDs for apis defined in fleet/apis directory
Arvindthiru
force-pushed
the
removeKruise
branch
from
daeb64a
to
af1c036
Compare
zhiying-lin
reviewed
Jun 21, 2024
There was a problem hiding this comment.
can we use a common crd for testing instead of creating multiple ones?
There was a problem hiding this comment.
this PR is already huge, maybe a follow up one?
There was a problem hiding this comment.
can we put the test file into a test common folder? so it can be reused.
ryanzhang-oss
approved these changes
Jun 21, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Removing the kruise package dependency from repo.