-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new test CRD to replace kruise API #856
Conversation
There was an error handling pipeline event 4a302cda-8d57-441d-b73c-30bdcc599603. |
@@ -233,7 +233,7 @@ CRD_OPTIONS ?= "crd" | |||
.PHONY: manifests | |||
manifests: $(CONTROLLER_GEN) | |||
$(CONTROLLER_GEN) \ | |||
$(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases | |||
$(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./apis/..." output:crd:artifacts:config=config/crd/bases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This done to ensure we only generate CRDs for apis defined in fleet/apis directory
daeb64a
to
af1c036
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use a common crd for testing instead of creating multiple ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR is already huge, maybe a follow up one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we put the test file into a test common folder? so it can be reused.
Description of your changes
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Removing the kruise package dependency from repo.