fix: failed placement change need to trigger work generator copy to binding #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanzhang-oss
force-pushed
the
fix-failed-placement-watch
branch
from
b3d57c8
to
faee9e2
Compare
ryanzhang-oss
force-pushed
the
fix-failed-placement-watch
branch
from
faee9e2
to
572ab98
Compare
zhiying-lin
reviewed
Jul 12, 2024
Arvindthiru
force-pushed
the
fix-failed-placement-watch
branch
from
695935a
to
0d2313a
Compare
ryanzhang-oss
commented
Jul 15, 2024
ryanzhang-oss
force-pushed
the
fix-failed-placement-watch
branch
from
52f140c
to
9502209
Compare
michaelawyu
previously approved these changes
Jul 17, 2024
| for _, tc := range tests { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| got := IsFailedResourcePlacementsEqual(tc.old, tc.new) | ||
| if diff := cmp.Diff(tc.want, got); diff != "" { |
There was a problem hiding this comment.
Also a nit, but since the diff is just comparing two bool values, it might be better to just use a equality check here
ryanzhang-oss
force-pushed
the
fix-failed-placement-watch
branch
from
94504a4
to
015dc12
Compare
Arvindthiru
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Verified that both the new e2e and integration test failed without the fix.