Support for more complex message from manifest commit message to dispatch event. (To handle flux image automation where list images is set by default). Fix errors with deploys being marked failed prematurely.

[joshuadmatthews]

A few updates to handle using this with flux image automation, and also to resolve an issue where successful commits get marked as failed prematurely.

1. Add try/except around extracting the runId and commitId from the source commit message, also passing along the unparsed commit message to support cases like flux image automation where there may be multiple image updates from commits/runs batched into a single manifest commit, and where it may be difficult to add a commit message formatted for extracting a runId/commitId.

2. Changed DependencyNotReady mapping from error to pending. Once a commit status with error status is sent to github the commit itself goes into the failure status, and from there gitops-connector stop processing further messages for that commit. DependencyNotReady can be emitted during a deployment that is ultimately successful. I also think HealthCheckFailed may have the same issues, a health check may fail as a container is initializing and then ultimately end up succeeding so we wouldn't want a single failure to cause a failed commit I don't think?

This discussion from flux maintainer suggests that DependencyNotReady just means reconciliation is in progress and not an indication of failure.
fluxcd/flux2#1160

Also I am unsure how to test this in my own cluster ahead of time, so just wanted to call out that these changes haven't been tested live but I believe they are simple enough.

[joshuadmatthews]

@microsoft-github-policy-service agree company="Beeline"

[joshuadmatthews]

@eedorenko are you available to review?

[joshuadmatthews]

I have figured out a way to avoid DependencyNotReady marking the commit as failure by filtering that event out of my flux alerts, this is less than ideal though IMO I would rather the event be sent just not to mark the commit as failure.

apiVersion: notification.toolkit.fluxcd.io/v1beta1
kind: Alert
metadata:
  name: gitops-connector
  namespace: flux-system
spec:
  eventSeverity: info
  eventSources:
  - kind: GitRepository
    name: myrepo
  - kind: Kustomization
    name: mykustomization
  providerRef:
    name: gitops-connector
  exclusionList:
    - "Dependencies do not meet ready condition"

I have not been able to work around the runID commitID parsing since it parses them based on "/" characters and flux image automation provides only a list of images that were updated as the commit message and they contains a "/" with no way for me to remove it.

[eedorenko]

lgtm