Skip to content

Commit

Permalink
add test coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
Xinyue.Wang authored and Xinyue.Wang committed Jun 27, 2023
1 parent 545e7de commit 4e44750
Showing 1 changed file with 56 additions and 1 deletion.
57 changes: 56 additions & 1 deletion wait_any_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ func TestWaitAny(t *testing.T) {
// should finish after right away
assert.True(t, elapsed < 2*time.Millisecond, fmt.Sprintf("actually elapsed: %v", elapsed))

start = time.Now()
countingTsk1 := asynctask.Start(ctx, getCountingTask(10, "countingPer40ms", 40*time.Millisecond))
countingTsk2 := asynctask.Start(ctx, getCountingTask(10, "countingPer20ms", 20*time.Millisecond))
countingTsk3 = asynctask.Start(ctx, getCountingTask(10, "countingPer2ms", 2*time.Millisecond))
start = time.Now()
err = asynctask.WaitAny(ctx, &asynctask.WaitAnyOptions{FailFast: true}, countingTsk1, countingTsk2, countingTsk3)
elapsed = time.Since(start)
assert.NoError(t, err)
Expand All @@ -42,6 +42,31 @@ func TestWaitAny(t *testing.T) {
time.Sleep(1 * time.Millisecond)
}

func TestWaitAnyContextCancel(t *testing.T) {
t.Parallel()
ctx, cancelTaskExecution := newTestContextWithTimeout(t, 2*time.Second)

start := time.Now()

countingTsk1 := asynctask.Start(ctx, getCountingTask(10, "countingPer40ms", 40*time.Millisecond))
countingTsk2 := asynctask.Start(ctx, getCountingTask(10, "countingPer20ms", 20*time.Millisecond))
go func() {
time.Sleep(5 * time.Millisecond)
cancelTaskExecution()
}()
err := asynctask.WaitAny(ctx, nil, countingTsk1, countingTsk2)
elapsed := time.Since(start)
assert.Error(t, err)
assert.Equal(t, "WaitAny context canceled", err.Error(), "expecting context canceled error")
// should finish right after countingTsk3
assert.True(t, elapsed >= 5*time.Millisecond && elapsed < 200*time.Millisecond, fmt.Sprintf("actually elapsed: %v", elapsed))

// counting task do testing.Logf in another go routine
// while testing.Logf would cause DataRace error when test is already finished: https://github.com/golang/go/issues/40343
// wait minor time for the go routine to finish.
time.Sleep(1 * time.Millisecond)
}

func TestWaitAnyErrorCase(t *testing.T) {
t.Parallel()
ctx, cancelTaskExecution := newTestContextWithTimeout(t, 3*time.Second)
Expand All @@ -58,6 +83,7 @@ func TestWaitAnyErrorCase(t *testing.T) {
completedTskState := completedTsk.State()
assert.Equal(t, asynctask.StateCompleted, completedTskState, "completed task should finished")

start = time.Now()
countingTsk := asynctask.Start(ctx, getCountingTask(10, "countingPer40ms", 40*time.Millisecond))
errorTsk = asynctask.Start(ctx, getErrorTask("expected error", 10*time.Millisecond))
panicTsk := asynctask.Start(ctx, getPanicTask(20*time.Millisecond))
Expand All @@ -84,6 +110,34 @@ func TestWaitAnyErrorCase(t *testing.T) {
time.Sleep(1 * time.Millisecond)
}

func TestWaitAnyAllFailCase(t *testing.T) {
t.Parallel()
ctx, cancelTaskExecution := newTestContextWithTimeout(t, 3*time.Second)

start := time.Now()
errorTsk := asynctask.Start(ctx, getErrorTask("expected error", 10*time.Millisecond))
panicTsk := asynctask.Start(ctx, getPanicTask(20*time.Millisecond))
err := asynctask.WaitAny(ctx, nil, errorTsk, panicTsk)
assert.Error(t, err)

panicTskState := panicTsk.State()
errTskState := errorTsk.State()
elapsed := time.Since(start)
cancelTaskExecution() // all assertion variable captured, cancel counting task

assert.Equal(t, "expected error", err.Error(), "expecting first error")
// should finsh after both error
assert.True(t, elapsed >= 20*time.Millisecond, fmt.Sprintf("actually elapsed: %v", elapsed))

assert.Equal(t, asynctask.StateFailed, errTskState, "error task should failed")
assert.Equal(t, asynctask.StateFailed, panicTskState, "panic task should Not failed")

// counting task do testing.Logf in another go routine
// while testing.Logf would cause DataRace error when test is already finished: https://github.com/golang/go/issues/40343
// wait minor time for the go routine to finish.
time.Sleep(1 * time.Millisecond)
}

func TestWaitAnyErrorWithFailFastCase(t *testing.T) {
t.Parallel()
ctx, cancelTaskExecution := newTestContextWithTimeout(t, 3*time.Second)
Expand All @@ -98,6 +152,7 @@ func TestWaitAnyErrorWithFailFastCase(t *testing.T) {
// should finish after right away
assert.True(t, elapsed < 20*time.Millisecond, fmt.Sprintf("actually elapsed: %v", elapsed))

start = time.Now()
countingTsk := asynctask.Start(ctx, getCountingTask(10, "countingPer40ms", 40*time.Millisecond))
errorTsk = asynctask.Start(ctx, getErrorTask("expected error", 10*time.Millisecond))
panicTsk := asynctask.Start(ctx, getPanicTask(20*time.Millisecond))
Expand Down

0 comments on commit 4e44750

Please sign in to comment.