Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitall fix write on closed channel #26

Merged
merged 14 commits into from
Apr 5, 2023

Conversation

haitch
Copy link
Member

@haitch haitch commented Apr 4, 2023

fix a bug where we publish to a closed channel, by not close the channel.

  • rely on go garbage collection to cleanup it.
  • this has assumption that user task eventually finish.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #26 (f3f5e24) into master (33f06ef) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   96.40%   96.34%   -0.07%     
==========================================
  Files           5        5              
  Lines         167      164       -3     
==========================================
- Hits          161      158       -3     
  Misses          4        4              
  Partials        2        2              
Impacted Files Coverage Δ
wait_all.go 91.66% <ø> (-0.65%) ⬇️
task.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haitch haitch marked this pull request as ready for review April 5, 2023 17:12
@haitch haitch changed the title Haitao/waitall fix closed channel waitall fix closed channel Apr 5, 2023
@haitch haitch changed the title waitall fix closed channel waitall fix write on closed channel Apr 5, 2023
@biefy
Copy link

biefy commented Apr 5, 2023

r+ biefy

@biefy biefy self-assigned this Apr 5, 2023
@haitch haitch merged commit a7094e4 into master Apr 5, 2023
@haitch haitch deleted the haitao/waitall_fix_closed_channel branch November 12, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants