Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WaitAny #32

Merged
merged 7 commits into from
Jun 27, 2023
Merged

Add WaitAny #32

merged 7 commits into from
Jun 27, 2023

Conversation

Xinyue-Wang
Copy link
Contributor

WaitAny will exit on first finished task or first error

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #32 (8d6c81f) into master (d9e07a1) will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   98.17%   98.48%   +0.31%     
==========================================
  Files           5        6       +1     
  Lines         164      198      +34     
==========================================
+ Hits          161      195      +34     
  Misses          2        2              
  Partials        1        1              
Impacted Files Coverage Δ
wait_any.go 100.00% <100.00%> (ø)

Copy link
Member

@haitch haitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, please add 2 test case on 0 input task and on a success case.

wait_any.go Outdated Show resolved Hide resolved
wait_any.go Show resolved Hide resolved
wait_any.go Outdated Show resolved Hide resolved
wait_any.go Outdated Show resolved Hide resolved
@Xinyue-Wang Xinyue-Wang requested a review from haitch June 27, 2023 23:42
@Xinyue-Wang Xinyue-Wang merged commit 4c78f32 into Azure:master Jun 27, 2023
3 checks passed
wait_any.go Outdated
}
}

// we have at least 1 error when FailOnAnyError is not set, return first one.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has to be all task failed to hit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants