Skip to content

Commit

Permalink
chore: rename accessmode type in CRD (#95)
Browse files Browse the repository at this point in the history
Based on the discussion whiling writing the design doc.

Co-authored-by: guofei <[email protected]>
  • Loading branch information
Fei-Guo and Fei-Guo committed Oct 20, 2023
1 parent 5eb9a59 commit 1be4d68
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions api/v1alpha1/workspace_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ const (
PresetFalcon7BInstructModel = PresetFalcon7BModel + "-instruct"
PresetFalcon40BInstructModel = PresetFalcon40BModel + "-instruct"

ModelAccessModePublic ModelAccessMode = "public"
ModelAccessModePrivate ModelAccessMode = "private"
ModelImageAccessModePublic ModelImageAccessMode = "public"
ModelImageAccessModePrivate ModelImageAccessMode = "private"
)

// ResourceSpec desicribes the resource requirement of running the workload.
Expand Down Expand Up @@ -68,7 +68,7 @@ type ResourceSpec struct {
type ModelName string

// +kubebuilder:validation:Enum=public;private
type ModelAccessMode string
type ModelImageAccessMode string

type PresetMeta struct {
// Name of the supported models with preset configurations.
Expand All @@ -78,7 +78,7 @@ type PresetMeta struct {
// If this field is "private", user needs to provide the private image information in PresetOptions.
// +bebuilder:default:="public"
// +optional
AccessMode ModelAccessMode `json:"accessMode,omitempty"`
AccessMode ModelImageAccessMode `json:"accessMode,omitempty"`
}

type PresetOptions struct {
Expand Down

0 comments on commit 1be4d68

Please sign in to comment.