Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor to implement model plugin - part 3 #189

Merged
merged 5 commits into from
Dec 13, 2023
Merged

chore: Refactor to implement model plugin - part 3 #189

merged 5 commits into from
Dec 13, 2023

Conversation

Fei-Guo
Copy link
Collaborator

@Fei-Guo Fei-Guo commented Dec 13, 2023

This change activates all model plugins.

  • Remove all hard coded model name in workspace_controller.go by using the plugin modelregister.
  • Fix related UTs
  • Change the model interface for better abstraction
  • Change to use Deployment for llama2-7b models.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (2d0c593) 77.05% compared to head (31c7472) 77.89%.

Files Patch % Lines
pkg/controllers/workspace_controller.go 67.74% 6 Missing and 4 partials ⚠️
pkg/inference/preset-inferences.go 85.71% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   77.05%   77.89%   +0.84%     
==========================================
  Files           9        9              
  Lines        1142     1095      -47     
==========================================
- Hits          880      853      -27     
+ Misses        226      208      -18     
+ Partials       36       34       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fei-Guo Fei-Guo merged commit e0f3a35 into main Dec 13, 2023
9 of 10 checks passed
@Fei-Guo Fei-Guo deleted the fguo-dev1 branch December 13, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants