Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Part 3 - Update E2E tests for new Build Preset Pipeline #220

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Jan 29, 2024

In this PR we:

  1. Place e2e configuration params in a separate JSON
  2. Switch from using a hardcoded env variable for image tag version -> Using support-models.yaml tag as source of truth
  3. Prevent empty matrix error during build preset pipeline
  4. Test/Prod Image Handling Scenarios (See Below)

Discussion:
This PR addresses three scenarios for image handling:

  1. Absent in Test ACR: Logs an error and skips E2E.
  2. Present in Test but Absent in Prod ACR: Executes E2E tests (and upon manual trigger and successful E2E, imports the image to Prod)
  3. Present in Both Test and Prod ACRs: Currently, E2E tests run without importing.

For the third scenario, to streamline our process and enforce tagging discipline, we could skip E2E tests for images already in Prod, only logging a notice. Thoughts? Want to ensure consensus before finalizing.

@ishaansehgal99 ishaansehgal99 changed the title feat: Part 5 - Update e2e tests to reflect new build preset pipeline feat: Part 5 - Update E2E tests to reflect new build preset pipeline Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9c766f) 66.10% compared to head (90cf423) 66.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   66.10%   66.10%           
=======================================
  Files          14       14           
  Lines        1372     1372           
=======================================
  Hits          907      907           
  Misses        427      427           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 changed the title feat: Part 5 - Update E2E tests to reflect new build preset pipeline feat: Part 5 - Update E2E tests for new Build Preset Pipeline Jan 29, 2024
@ishaansehgal99 ishaansehgal99 changed the title feat: Part 5 - Update E2E tests for new Build Preset Pipeline feat: Part 3 - Update E2E tests for new Build Preset Pipeline Jan 29, 2024
@Fei-Guo Fei-Guo merged commit ae881d2 into main Jan 29, 2024
9 checks passed
@Fei-Guo Fei-Guo deleted the Ishaan/e2e-preset-fixes branch January 29, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants