fix: Eliminate Unnecessary Process Group Creation in Worker Initialization #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
ishaansehgal99
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 65.27% 65.27%
=======================================
Files 14 14
Lines 1123 1123
=======================================
Hits 733 733
Misses 352 352
Partials 38 38 ☔ View full report in Codecov by Sentry. |
Fei-Guo
approved these changes
Feb 15, 2024
ishaansehgal99
had a problem deploying
to
e2e-test
GitHub Actions
Error
ishaansehgal99
changed the title
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
ishaansehgal99
had a problem deploying
to
e2e-test
GitHub Actions
Failure
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
ishaansehgal99
changed the title
Fei-Guo
approved these changes
Feb 19, 2024
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
ishaansehgal99
had a problem deploying
to
e2e-test
GitHub Actions
Failure
ishaansehgal99
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for using new python base image for llama models
Creating and destroying process groups for each worker proves unnecessary - instead exit conditions and sigterm signal for shutting down each worker proved reliable after testing.