Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add additional e2e tests #256

Merged
merged 13 commits into from
Feb 28, 2024
Merged

feat: Add additional e2e tests #256

merged 13 commits into from
Feb 28, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Feb 24, 2024

Add e2e tests for mistral and phi-2

Note: This PR also:

  1. Checks deletion timestamp - to ensure nodes being deleted aren't considered qualified
  2. Corrects mistral version from 0.0.1 -> 0.0.2. 0.0.2 is actually the latest/correct version

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.33%. Comparing base (de2b45c) to head (806a2dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   65.27%   65.33%   +0.06%     
==========================================
  Files          14       14              
  Lines        1123     1125       +2     
==========================================
+ Hits          733      735       +2     
  Misses        352      352              
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fei-Guo Fei-Guo merged commit 7bd5641 into main Feb 28, 2024
13 checks passed
@Fei-Guo Fei-Guo deleted the Ishaan/addt-preset-tests branch February 28, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants