feat: Initialize Fine-Tuning Interface and Core Methods - Part 3 #308

ishaansehgal99 · 2024-03-20T21:01:05Z

Setup

…tion

…e-tuning

…tion

…n/ft

…tion

…n/ft

Fei-Guo

Replace all "training" with "tuning".

We can deal with workspace conditions in future changes.

api/v1alpha1/workspace_condition_types.go

pkg/controllers/workspace_controller.go

codecov-commenter · 2024-03-21T19:36:42Z

Codecov Report

Attention: Patch coverage is 10.25641% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 62.62%. Comparing base (8d0976f) to head (6a47da0).

Files	Patch %	Lines
pkg/controllers/workspace_controller.go	0.00%	32 Missing and 2 partials ⚠️
pkg/inference/preset-inferences.go	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   63.87%   62.62%   -1.26%     
==========================================
  Files          14       14              
  Lines        1301     1327      +26     
==========================================
  Hits          831      831              
- Misses        432      458      +26     
  Partials       38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/v1alpha1/workspace_condition_types.go

pkg/controllers/workspace_controller.go

pkg/model/interface.go

pkg/tuning/preset-tuning.go

…n/ft

ishaansehgal99 added 26 commits March 18, 2024 10:37

feat: spec level validation

da63f93

feat: Added validation checks for TuningSpec, DataSource, DataDestina…

a4f45e6

…tion

fix: prevent toggling

a9bbe7a

fix: validation fixes

d73ef65

feat: Add UTs for workspace validation

3fa0e46

Merge branch 'main' into Ishaan/fine-tuning

13153f3

Merge branch 'main' of https://github.com/Azure/kaito into Ishaan/fin…

5a6b64f

…e-tuning

fix: Update CRD to use pointers

392ff40

Merge branch 'main' of https://github.com/Azure/kaito into Ishaan/fin…

b2e2b26

…e-tuning

fix: Add name flag

6c347c9

feat: Setup Interface for fine tuning

1a14872

feat: spec level validation

b21b99f

feat: Added validation checks for TuningSpec, DataSource, DataDestina…

75cacae

…tion

fix: prevent toggling

5f9e132

fix: validation fixes

9f4e820

feat: Add UTs for workspace validation

a16351d

fix: Update CRD to use pointers

d2cd230

fix: Add name flag

082844d

feat: Setup Interface for fine tuning

56409a7

Merge branch 'Ishaan/ft' of https://github.com/Azure/kaito into Ishaa…

ffa809a

…n/ft

feat: Added validation checks for TuningSpec, DataSource, DataDestina…

1a4b5ac

…tion

fix: validation fixes

29210a7

feat: Setup Interface for fine tuning

4a93976

feat: spec level validation

36977c4

feat: Added validation checks for TuningSpec, DataSource, DataDestina…

b738b47

…tion

Merge branch 'Ishaan/ft' of https://github.com/Azure/kaito into Ishaa…

1a73ca4

…n/ft

ishaansehgal99 requested review from Fei-Guo and helayoty as code owners March 20, 2024 21:01

ishaansehgal99 had a problem deploying to unit-tests March 20, 2024 21:01 — with GitHub Actions Error

ishaansehgal99 had a problem deploying to e2e-test March 20, 2024 21:01 — with GitHub Actions Error

ishaansehgal99 temporarily deployed to e2e-test March 21, 2024 13:48 — with GitHub Actions Inactive

ishaansehgal99 temporarily deployed to unit-tests March 21, 2024 13:48 — with GitHub Actions Inactive

Fei-Guo reviewed Mar 21, 2024

View reviewed changes

api/v1alpha1/workspace_condition_types.go Outdated Show resolved Hide resolved

pkg/controllers/workspace_controller.go Show resolved Hide resolved

pkg/controllers/workspace_controller.go Outdated Show resolved Hide resolved

fix: workspace condition

107c501

ishaansehgal99 had a problem deploying to unit-tests March 21, 2024 19:17 — with GitHub Actions Error

ishaansehgal99 had a problem deploying to e2e-test March 21, 2024 19:17 — with GitHub Actions Error

fix: workspace condition

c80eada

ishaansehgal99 temporarily deployed to e2e-test March 21, 2024 19:19 — with GitHub Actions Inactive

ishaansehgal99 temporarily deployed to unit-tests March 21, 2024 19:19 — with GitHub Actions Inactive

Merge branch 'main' of https://github.com/Azure/kaito into Ishaan/ft

3932bf4

ishaansehgal99 temporarily deployed to e2e-test March 26, 2024 20:28 — with GitHub Actions Inactive

ishaansehgal99 temporarily deployed to unit-tests March 26, 2024 20:28 — with GitHub Actions Inactive

Merge branch 'main' into Ishaan/ft

565e2ae

ishaansehgal99 had a problem deploying to unit-tests March 29, 2024 03:10 — with GitHub Actions Error

ishaansehgal99 had a problem deploying to e2e-test March 29, 2024 03:10 — with GitHub Actions Error

Fei-Guo reviewed Mar 29, 2024

View reviewed changes

api/v1alpha1/workspace_condition_types.go Outdated Show resolved Hide resolved

pkg/controllers/workspace_controller.go Outdated Show resolved Hide resolved

pkg/model/interface.go Outdated Show resolved Hide resolved

pkg/tuning/preset-tuning.go Outdated Show resolved Hide resolved

ishaansehgal99 added 2 commits March 29, 2024 15:41

fix: address comments

860108f

Merge branch 'Ishaan/ft' of https://github.com/Azure/kaito into Ishaa…

76b10e4

…n/ft

ishaansehgal99 had a problem deploying to unit-tests March 29, 2024 22:41 — with GitHub Actions Error

ishaansehgal99 had a problem deploying to e2e-test March 29, 2024 22:41 — with GitHub Actions Error

Merge branch 'main' of https://github.com/Azure/kaito into Ishaan/ft

56609e9

ishaansehgal99 had a problem deploying to unit-tests March 29, 2024 22:43 — with GitHub Actions Error

ishaansehgal99 had a problem deploying to e2e-test March 29, 2024 22:43 — with GitHub Actions Error

fix: remove code

6a47da0

ishaansehgal99 temporarily deployed to unit-tests March 29, 2024 22:45 — with GitHub Actions Inactive

ishaansehgal99 temporarily deployed to e2e-test March 29, 2024 22:45 — with GitHub Actions Inactive

Fei-Guo approved these changes Mar 29, 2024

View reviewed changes

ishaansehgal99 merged commit 08dd1f4 into main Apr 1, 2024
6 checks passed

ishaansehgal99 deleted the Ishaan/ft branch April 1, 2024 22:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Initialize Fine-Tuning Interface and Core Methods - Part 3 #308

feat: Initialize Fine-Tuning Interface and Core Methods - Part 3 #308

ishaansehgal99 commented Mar 20, 2024

Fei-Guo left a comment

codecov-commenter commented Mar 21, 2024 •

edited

Loading

feat: Initialize Fine-Tuning Interface and Core Methods - Part 3 #308

feat: Initialize Fine-Tuning Interface and Core Methods - Part 3 #308

Conversation

ishaansehgal99 commented Mar 20, 2024

Fei-Guo left a comment

Choose a reason for hiding this comment

codecov-commenter commented Mar 21, 2024 • edited Loading

Codecov Report

codecov-commenter commented Mar 21, 2024 •

edited

Loading