Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Factoring out reusable presets logic - Part 4 #332

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Apr 1, 2024

Reason for Change:
Refactoring out reusable logic - in preparation to also be used by tuning preset

@ishaansehgal99 ishaansehgal99 changed the title chore: Factoring out reusable inference and tuning presets logic chore: Factoring out reusable presets logic Apr 1, 2024
@ishaansehgal99 ishaansehgal99 changed the title chore: Factoring out reusable presets logic chore: Factoring out reusable presets logic - Part 4 Apr 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 62.89%. Comparing base (ee9101a) to head (6b2c9f9).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/inference/preset-inferences.go 73.91% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   63.87%   62.89%   -0.99%     
==========================================
  Files          14       14              
  Lines        1301     1307       +6     
==========================================
- Hits          831      822       -9     
- Misses        432      447      +15     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 enabled auto-merge (squash) April 2, 2024 01:35
@ishaansehgal99 ishaansehgal99 merged commit 77aa95b into main Apr 2, 2024
5 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/nit branch April 2, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants