Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add default configmaps - Part 5 #346

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Apr 10, 2024

Reason for Change:
Provide a default configmaps in the helm chart.

Notes for Reviewers:
An env variable release namespace is passed in for future use so that the controller will be able to find where the configmap is deployed.

@ishaansehgal99 ishaansehgal99 changed the title feat: Add default configmap feat: Add default configmap - Part 6 Apr 10, 2024
@ishaansehgal99 ishaansehgal99 changed the title feat: Add default configmap - Part 6 feat: Add default configmap - Part 5 Apr 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.89%. Comparing base (fde6369) to head (d57f64b).
Report is 2 commits behind head on main.

❗ Current head d57f64b differs from pull request most recent head dfa55e0. Consider uploading reports for the commit dfa55e0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   62.89%   62.89%           
=======================================
  Files          14       14           
  Lines        1307     1307           
=======================================
  Hits          822      822           
  Misses        447      447           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 changed the title feat: Add default configmap - Part 5 feat: Add default configmaps - Part 5 Apr 10, 2024
@ishaansehgal99 ishaansehgal99 merged commit f88b529 into main Apr 10, 2024
4 of 8 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/configmap branch April 10, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants