Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add global client, accessible via webhooks #353

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

ishaansehgal99
Copy link
Collaborator

@ishaansehgal99 ishaansehgal99 commented Apr 16, 2024

Reason for Change:
Add global client, accessible via webhooks

In this PR I also
Separate setup and execution phase of webhook server, allows us to handle setup errors and setup context before attempting to run the webhook server

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.89%. Comparing base (fde6369) to head (bb7d624).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   62.89%   62.89%           
=======================================
  Files          14       14           
  Lines        1307     1307           
=======================================
  Hits          822      822           
  Misses        447      447           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 merged commit e2f5e25 into main Apr 16, 2024
6 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/client branch April 16, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants