Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update CRD to add Volume and ConfigTemplate #356

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: Update CRD to add Volume and ConfigTemplate #356

merged 2 commits into from
Apr 18, 2024

Conversation

Fei-Guo
Copy link
Collaborator

@Fei-Guo Fei-Guo commented Apr 18, 2024

Reason for Change:
This change removes hostPath field in DataSource and DataDestination struct. Instead, a standard K8s VolumeSource API is used to specify the volumes used by the tuning Job. This will provide the highest flexibility for users to load/store the data. HostPath field is hard to use in practice.

This change also renames the Config to ConfigTemplate because the final configmap used by the tuning job will be generated by the controller based on the template. The new name is clearer.

Notes for Reviewers:
We will revisit how to do validation check for the Volume field because it is a fairly complicated API.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 62.39%. Comparing base (fde6369) to head (e83ea67).
Report is 6 commits behind head on main.

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   62.89%   62.39%   -0.50%     
==========================================
  Files          14       14              
  Lines        1307     1311       +4     
==========================================
- Hits          822      818       -4     
- Misses        447      455       +8     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fei-Guo Fei-Guo merged commit bf4acba into main Apr 18, 2024
5 checks passed
@Fei-Guo Fei-Guo deleted the fguo-dev1 branch April 18, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants