-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add v1beta1 API for Karpenter #362
Conversation
3b4a643
to
8e278a0
Compare
8e278a0
to
88f95c4
Compare
88f95c4
to
86940d6
Compare
86940d6
to
bb0f468
Compare
bb0f468
to
c209c82
Compare
c209c82
to
18bb06b
Compare
18bb06b
to
f54cd31
Compare
f54cd31
to
2774213
Compare
2774213
to
2f6ef1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
- Coverage 62.89% 62.54% -0.35%
==========================================
Files 14 27 +13
Lines 1307 1901 +594
==========================================
+ Hits 822 1189 +367
- Misses 447 650 +203
- Partials 38 62 +24 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Heba Elayoty <[email protected]>
Signed-off-by: Heba Elayoty <[email protected]>
d8323fc
to
1765318
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Heba Elayoty <[email protected]>
Reason for Change:
This PR is the first of the upcoming work to migrate to use
NodeClaim
from v1beta1 Karpenter API.preset_tuning.go
main.go
due to updating k8s version to1.29.3
Ginkgo
version to1.17.1
nodeClaim
and karpenternodePool
to Kaito clusterrole .Requirements
Issue Fixed:
Notes for Reviewers: