chore: remove gpu-provisioner chart from kaito repo #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heba Elayoty <[email protected]>
helayoty
force-pushed
the
helayoty/remove-chart-add-crds
branch
from
78a0bee
to
6a45ab9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #372 +/- ##
==========================================
- Coverage 62.89% 61.74% -1.15%
==========================================
Files 14 29 +15
Lines 1307 2227 +920
==========================================
+ Hits 822 1375 +553
- Misses 447 785 +338
- Partials 38 67 +29 ☔ View full report in Codecov by Sentry. |
helayoty
force-pushed
the
helayoty/remove-chart-add-crds
branch
from
6a45ab9
to
717603e
Compare
helayoty
force-pushed
the
helayoty/remove-chart-add-crds
branch
from
717603e
to
ff21e43
Compare
helayoty
force-pushed
the
helayoty/remove-chart-add-crds
branch
from
ff21e43
to
ded1ad4
Compare
Fei-Guo
approved these changes
May 3, 2024
helayoty
force-pushed
the
helayoty/remove-chart-add-crds
branch
from
ded1ad4
to
fbe2597
Compare
Signed-off-by: Heba Elayoty <[email protected]>
helayoty
force-pushed
the
helayoty/remove-chart-add-crds
branch
from
fbe2597
to
90bb46f
Compare
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Jun 7, 2024
**Reason for Change**: - Since [gpu-provisioner](Azure/gpu-provisioner@4272b4f) provided a way to install the hosted chart, this PR is to remove the duplicate helm chart. - Karpenter and gpu-provisioner CRDs is added to the Kaito chart. - Update the doc. **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: Heba Elayoty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Requirements
Issue Fixed:
Notes for Reviewers: