Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add karpenter labels to nodeClaim #373

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

helayoty
Copy link
Collaborator

@helayoty helayoty commented May 8, 2024

Reason for Change:

  • Add DoNotDisrupt=true label to prevent Karpenter from scaling down.
  • Make sure to add Fake nodepool name to prevent Karpenter from scaling up.
  • Add Unit tests for generate Nodeclaim and for workspace status.

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Signed-off-by: Heba Elayoty <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.09%. Comparing base (cb2d964) to head (d37f04a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   60.62%   61.09%   +0.46%     
==========================================
  Files          29       29              
  Lines        2301     2303       +2     
==========================================
+ Hits         1395     1407      +12     
+ Misses        835      828       -7     
+ Partials       71       68       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helayoty helayoty enabled auto-merge (squash) May 8, 2024 02:28
@helayoty helayoty merged commit 675a245 into main May 8, 2024
6 checks passed
@helayoty helayoty deleted the helayoty/karpenter-labels branch May 8, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants