Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ginkgo version for e2e test #403

Merged
merged 2 commits into from
May 11, 2024
Merged

Conversation

helayoty
Copy link
Collaborator

@helayoty helayoty commented May 11, 2024

Reason for Change:
As a result of bumping the ginkgo package in go.mod #394 , the local binary version needs to be the same one.
Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.09%. Comparing base (25a2b10) to head (d67f3b3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   61.09%   61.09%           
=======================================
  Files          29       29           
  Lines        2303     2303           
=======================================
  Hits         1407     1407           
  Misses        828      828           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@helayoty helayoty merged commit 2c05921 into main May 11, 2024
6 checks passed
@helayoty helayoty deleted the helayoty/ginkgo-fix branch May 11, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants