Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Min GPU Memory Requirement #443

Merged
merged 3 commits into from
May 30, 2024
Merged

feat: Add Min GPU Memory Requirement #443

merged 3 commits into from
May 30, 2024

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:

  1. Add interface field TuningMethodGPUMemory - Min GPU memory per tuning method (batch size 1).
  2. Fix bug(s) in tuning ConfigMap creation

Fei-Guo
Fei-Guo reviewed May 30, 2024
View reviewed changes
pkg/model/interface.go Outdated Show resolved Hide resolved
@ishaansehgal99 ishaansehgal99 merged commit 76a966b into main May 30, 2024
5 of 6 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/per-gpu-mem branch May 30, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishaansehgal99 @Fei-Guo