-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: e2e test for adapters and validation of adapters #483
Conversation
cc0f886
to
903e9e0
Compare
903e9e0
to
5570b5d
Compare
test/e2e/inference_with_adapters.go
Outdated
var err error | ||
runLlama13B, err = strconv.ParseBool(os.Getenv("RUN_LLAMA_13B")) | ||
if err != nil { | ||
// Handle error or set a default value | ||
fmt.Print("Error: RUN_LLAMA_13B ENV Variable not set") | ||
runLlama13B = false | ||
} | ||
|
||
aiModelsRegistry = utils.GetEnv("AI_MODELS_REGISTRY") | ||
aiModelsRegistrySecret = utils.GetEnv("AI_MODELS_REGISTRY_SECRET") | ||
supportedModelsYamlPath = utils.GetEnv("SUPPORTED_MODELS_YAML_PATH") | ||
|
||
// Load stable model versions | ||
configs, err := utils.GetModelConfigInfo(supportedModelsYamlPath) | ||
if err != nil { | ||
fmt.Printf("Failed to load model configs: %v\n", err) | ||
os.Exit(1) | ||
} | ||
|
||
modelInfo, err = utils.ExtractModelVersion(configs) | ||
if err != nil { | ||
fmt.Printf("Failed to extract stable model versions: %v\n", err) | ||
os.Exit(1) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicated from preset_test.go. We can make this a function
func loadTestEnvVars() {
var err error
runLlama13B, err = strconv.ParseBool(os.Getenv("RUN_LLAMA_13B"))
if err != nil {
fmt.Print("Error: RUN_LLAMA_13B ENV Variable not set")
runLlama13B = false
}
aiModelsRegistry = utils.GetEnv("AI_MODELS_REGISTRY")
aiModelsRegistrySecret = utils.GetEnv("AI_MODELS_REGISTRY_SECRET")
supportedModelsYamlPath = utils.GetEnv("SUPPORTED_MODELS_YAML_PATH")
}
func loadModelVersions() {
configs, err := utils.GetModelConfigInfo(supportedModelsYamlPath)
if err != nil {
fmt.Printf("Failed to load model configs: %v\n", err)
os.Exit(1)
}
modelInfo, err = utils.ExtractModelVersion(configs)
if err != nil {
fmt.Printf("Failed to extract stable model versions: %v\n", err)
os.Exit(1)
}
}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 60.92% 61.02% +0.09%
==========================================
Files 29 29
Lines 2559 2568 +9
==========================================
+ Hits 1559 1567 +8
- Misses 909 910 +1
Partials 91 91 ☔ View full report in Codecov by Sentry. |
5570b5d
to
2998e18
Compare
2998e18
to
ab43de0
Compare
4cf75ce
to
e914636
Compare
Signed-off-by: Bangqi Zhu <[email protected]>
Signed-off-by: Bangqi Zhu <[email protected]>
Signed-off-by: Bangqi Zhu <[email protected]>
e914636
to
5b04a62
Compare
**Reason for Change**: <!-- What does this PR improve or fix in Kaito? Why is it needed? --> **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: Bangqi Zhu <[email protected]> Co-authored-by: Bangqi Zhu <[email protected]>
Reason for Change:
Requirements
Issue Fixed:
Notes for Reviewers: