feat: Add cloud provider specific nodeClaim requirement #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heba Elayoty <[email protected]>
helayoty
force-pushed
the
helayoty/update-nodeclaim
branch
from
24ca1b9
to
ded2956
Compare
helayoty
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
+ Coverage 60.92% 61.01% +0.09%
==========================================
Files 29 29
Lines 2559 2588 +29
==========================================
+ Hits 1559 1579 +20
- Misses 909 918 +9
Partials 91 91 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Heba Elayoty <[email protected]>
Fei-Guo
approved these changes
Jul 3, 2024
smritidahal653
pushed a commit
to smritidahal653/kaito
that referenced
this pull request
Jul 12, 2024
**Reason for Change**: Pass the cloud provider name via helm chart so Kaito can set the cloud provider specific requirements for the `NodeClaim`. General updates: - Add consts for each of sku & gpu across the pkg files. **Requirements** - [x] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: Heba Elayoty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Pass the cloud provider name via helm chart so Kaito can set the cloud provider specific requirements for the
NodeClaim.General updates:
Requirements
Issue Fixed:
Notes for Reviewers: