Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preset Build Image Naming #497

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
Preset images use their model name as the name of the image by default. Instead we pass in seperate image name variable to name the image.

@ishaansehgal99 ishaansehgal99 changed the title nit: Fix Preset Build Image Naming fix: Fix Preset Build Image Naming Jul 4, 2024
@ishaansehgal99 ishaansehgal99 changed the title fix: Fix Preset Build Image Naming fix: Preset Build Image Naming Jul 4, 2024
@ishaansehgal99 ishaansehgal99 merged commit 9e12854 into main Jul 4, 2024
5 of 8 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/image-name-nit branch July 4, 2024 04:31
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Jul 12, 2024
**Reason for Change**:
Preset images use their model name as the name of the image by default.
Instead we pass in seperate image name variable to name the image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant