Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use SKU GPU Count in DeploymentSpec #541

Merged
merged 15 commits into from
Aug 6, 2024
Merged

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
Cases were workspace was not utilizing all available GPUs on machine by default this was causing slower inference requests and unused resources. This is the fix.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 52.83019% with 25 lines in your changes missing coverage. Please review.

Project coverage is 57.00%. Comparing base (ed546f0) to head (a9273a1).
Report is 21 commits behind head on main.

Files Patch % Lines
pkg/utils/common.go 50.00% 17 Missing and 1 partial ⚠️
pkg/tuning/preset-tuning.go 37.50% 5 Missing ⚠️
pkg/inference/preset-inferences.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   61.10%   57.00%   -4.11%     
==========================================
  Files          29       30       +1     
  Lines        2602     2912     +310     
==========================================
+ Hits         1590     1660      +70     
- Misses        921     1157     +236     
- Partials       91       95       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/utils/common.go Outdated Show resolved Hide resolved
pkg/inference/preset-inferences.go Show resolved Hide resolved
pkg/tuning/preset-tuning.go Outdated Show resolved Hide resolved
@ishaansehgal99 ishaansehgal99 merged commit 7899717 into main Aug 6, 2024
6 of 8 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/fix-gpu-usage branch August 6, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants