-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: patch for volumeMounts #546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0fd4b22
to
a792c30
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
- Coverage 61.10% 57.02% -4.09%
==========================================
Files 29 30 +1
Lines 2602 2927 +325
==========================================
+ Hits 1590 1669 +79
- Misses 921 1160 +239
- Partials 91 98 +7 ☔ View full report in Codecov by Sentry. |
a792c30
to
774d1bb
Compare
e3ef3a5
to
f538582
Compare
f538582
to
d5fc713
Compare
0bbcfc1
to
e333389
Compare
e333389
to
7082cab
Compare
7082cab
to
4736725
Compare
4736725
to
0492865
Compare
Fei-Guo
reviewed
Aug 7, 2024
Signed-off-by: Bangqi Zhu <[email protected]>
0492865
to
91e4eae
Compare
Fei-Guo
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
add volumeMounts and volume patch for initContainers
add nil check for annotations
Requirements
Issue Fixed:
Notes for Reviewers: