New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix a bug in counting existing nodes #88

Merged

Fei-Guo merged 1 commit into main from fguo-dev1

Oct 19, 2023

Collaborator

Fei-Guo commented Oct 19, 2023 •

edited

Loading

The validCurrentClusterNodeList should be used to check the existing nodes.
Also address a review comment from previous PR.

I will refactor the new machine count calculation in the follow up PR.


          fix: fix a bug in counting existing nodes

fd8b5bf

Fei-Guo requested review from helayoty and ishaansehgal99 as code owners

October 19, 2023 02:29

helayoty approved these changes

View reviewed changes

Fei-Guo merged commit 47305bc into main

5 checks passed

Fei-Guo deleted the fguo-dev1 branch

October 19, 2023 04:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet