feat: Add accessmode, custom image, and image secret #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaansehgal99
changed the title
ishaansehgal99
changed the title
Signed-off-by: Ishaan Sehgal <[email protected]>
Fei-Guo
reviewed
Oct 25, 2023
api/v1alpha1/workspace_validation.go
Outdated
| @@ -80,5 +84,10 @@ func (i *InferenceSpec) validateUpdate(old *InferenceSpec) (errs *apis.FieldErro | |||
| if (i.Template != nil && old.Template == nil) || (i.Template == nil && old.Template != nil) { | |||
| errs = errs.Also(apis.ErrGeneric("field cannot be unset/set if it was set/unset", "template")) | |||
| } | |||
|
|
|||
| if i.Preset.PresetMeta.AccessMode == "private" && i.Preset.PresetOptions.Image == "" { | |||
There was a problem hiding this comment.
This check is not needed for update case. Update always means old compares with new.
There was a problem hiding this comment.
Yes and I believe this check ensures image isn't changed:
!reflect.DeepEqual(i.Preset, old.Preset)
| default: | ||
| err := fmt.Errorf("preset model %s is not supported", presetName) | ||
| return inference.PresetInferenceParam{}, err | ||
| } | ||
|
|
||
| inferenceObj.AccessMode = string(wObj.Inference.Preset.PresetMeta.AccessMode) | ||
| if wObj.Inference.Preset.PresetOptions.Image != "" { |
There was a problem hiding this comment.
You need to check access mode here as well.
Fei-Guo
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set the custom image, image pull secrets, and access mode for the inference object. This would allow for pulling from a custom image.