Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media3 #166

Open
wants to merge 21 commits into
base: media3
Choose a base branch
from
Open

Media3 #166

wants to merge 21 commits into from

Conversation

ArchangelWTF
Copy link
Collaborator

@ArchangelWTF ArchangelWTF commented Sep 4, 2023

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Introduces Media3 (Fixes: #157)

@martijn00 This fully introduces Media3, I've updated the PackageId's as I think it would break to have media3 published on the current ExoPlayer Id's..

As well as that, if you merge this.. Could you set media3 as the main branch for this repository? This will allow us to keep the current develop and exoplayer branches should we need to do anything with them.

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current develop

@ArchangelWTF
Copy link
Collaborator Author

@martijn00 When you have time to look this over can you approve and merge this?

@Mackly
Copy link

Mackly commented Mar 2, 2024

Hi! Is there a reason why this has not been integrated and released to the nuget package ?

@ArchangelWTF
Copy link
Collaborator Author

@Mackly Because it was decided not to be adopted, also Xamarin will have a Media3 package available soon (Went into review this week: xamarin/AndroidX#710)

@Mackly
Copy link

Mackly commented Mar 5, 2024

Thanks for the reply, I am following closely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants