Some improvements and a feature #186

ramon18 · 2017-05-22T14:29:37Z

Hi,
I've made a few improvements and a new notification useful for gamers.
Cheers

…a lot the settings form.

FireEmerald

First of all the "window" or frame looks great and works well!

In total there are only minor things i noticed so far.
The existing code isn't well documented but this doesn't mean we have to continue with this approach.

FireEmerald · 2017-05-22T18:30:33Z

SoundSwitch/Framework/Banner/BannerManager.cs

+        /// <summary>
+        /// Show a banner notification with the given data
+        /// </summary>
+        /// <param name="data"></param>


Missing documentation

FireEmerald · 2017-05-22T18:36:07Z

SoundSwitch/Localization/SettingsStrings.de.resx

@@ -259,7 +259,8 @@
 		<value>Windows Benachrichtigung: Das Standard Windows Pop-Up.
 Akustische Benachrichtigung: Spielt einen Sound auf dem Wiedergabegerät ab.
 Angepasste akustische Benachrichtigung: Spielt einen selbst definierten Sound ab.
-Popup Benachrichtigung: Spezielle Form eines Windows Pop-ups.</value>
+Popup Benachrichtigung: Spezielle Form eines Windows Pop-ups.
+Banner: Verwendet eine benutzerdefinierte Form immer auf der Oberseite, kann nützlich sein, in bestimmten für In-Game-Nutzung, weil es steht über directdraw / opengl.</value>


To be synced with English comment - don't use translators.

FireEmerald · 2017-05-22T18:38:18Z

SoundSwitch/Localization/SettingsStrings.fr.resx

@@ -212,7 +212,8 @@
 		<value>Notif. Windows: Popup sur l'icone de système
 Notifi. Sonore: Joue un son
 Notif. Sonore Perso: Joue le son choisi
-Notif. Toast: Popup sur le coté de l'écran dans Windows 10.</value>
+Notif. Toast: Popup sur le coté de l'écran dans Windows 10.
+Notif. Bannière: Utilise une forme personnalisée toujours en haut, peut être utile pour certaines utilisations dans le jeu, car elle se situe au-dessus de directdraw / opengl.</value>


To be synced with English comment - don't use translators.

FireEmerald · 2017-05-22T18:41:08Z

SoundSwitch/Localization/SettingsStrings.resx

@@ -232,7 +232,8 @@
    <value>Windows Notification: The default windows tray pop-up.
 Sound Notification: Plays a sound on the switched Playback Device.
 Customized Sound Notification: Plays the specified sound on the switched Playback Device.
-Toast Notification: Uses a special form of the windows tray pop-up version.</value>
+Toast Notification: Uses a special form of the windows tray pop-up version.
+Banner: Uses a custom always-on-top form, may be useful for in-game usage because it stands above directdraw/opengl.</value>


" because it stands above directdraw/opengl" can be removed, the average gamer doesn't need this information.
Banner: Uses a custom always-on-top frame, useful for in-game usage.

FireEmerald · 2017-05-22T18:42:54Z

SoundSwitch/Framework/NotificationManager/NotificationCustomSoundEnum.cs

+
+namespace SoundSwitch.Framework.NotificationManager
+{
+    public enum NotificationCustomSoundEnum


Missing documentation

FireEmerald · 2017-05-22T18:43:53Z

SoundSwitch/Framework/NotificationManager/Notification/NotificationBanner.cs

+        {
+            var toastData = new BannerData
+            {
+                ImagePath = "file:///"+ApplicationPath.DefaultImagePath,


Path.Combine()

FireEmerald · 2017-05-22T18:44:39Z

SoundSwitch/Framework/Banner/BannerData.cs

+
+namespace SoundSwitch.Framework.Banner
+{
+    public class BannerData


Missing documentation

FireEmerald · 2017-05-22T18:48:34Z

SoundSwitch/Framework/Banner/BannerForm.cs

+                this.timerHide.Tick += TimerHide_Tick;
+            }
+            else
+                this.timerHide.Enabled = false;


Codestyle...

if (a == b) { Fly(); } else { Die(); }

FireEmerald · 2017-05-22T18:50:27Z

SoundSwitch/Framework/NotificationManager/Notification/NotificationBanner.cs

+        {
+            BannerManager.Setup();
+
+            // Available is all Windows versions


ramon18 · 2017-05-22T21:06:15Z

I completely agree with your appointments, I just was in a rush to complete this sharing… :)
You know, two kids, one of them has just 3 weeks ehh!
Most of the time, I do not take the time to share my work and therefore no one else benefits from it.

I've amended my last commit, please check if I missed something.
Thanks

…h stands above any directdraw/opengl windows.

Belphemur · 2017-05-24T01:42:34Z

Firstly congratulations 🎊 for your kid 😃 This looks great, I'll try it out ASAP and will surely release a beta version with it. Thanks @FireEmerald for the review and thank you for the PR. ⁣Sent from BlueMail

…

On May 22, 2017, 17:06, at 17:06, ramon18 ***@***.***> wrote: I completely agree with your appointments, I just was in a rush to complete this sharing… :) You know, two kinds, one of them has just 3 weeks ehh! Most of the time, I do not take the time to share my work and therefore no one else benefits from it. I've amended my last commit, please check if I missed something. Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #186 (comment)

Belphemur · 2017-05-25T11:34:03Z

I just reviewed the code and tried it.

This is magical! I'm going to set it as the new default.

@Belphemur

ToDo: French translation is missing for: (@Belphemur) - SettingsStrings.fr, notificationTooltip. - UpdateDownloadStrings, notSigned.

Belphemur · 2021-12-18T22:48:56Z

@all-contributors please add @ramon18 for code

allcontributors · 2021-12-18T22:49:05Z

@Belphemur

I've put up a pull request to add @ramon18! 🎉

ramon18 added 3 commits May 22, 2017 14:01

Auto detect visual studio edition during build.

d73dc6c

Ignore .vs directory.

23755e0

Notifications can inform if they require custom sound, this improves …

b9e51a9

…a lot the settings form.

ramon18 force-pushed the dev branch 3 times, most recently from 173ad1b to c5f329f Compare May 22, 2017 15:55

FireEmerald suggested changes May 22, 2017

View reviewed changes

ramon18 force-pushed the dev branch from c5f329f to cb9a8ec Compare May 22, 2017 21:05

Added support for "Banner" notification, an always-on-top banner whic…

2111002

…h stands above any directdraw/opengl windows.

ramon18 force-pushed the dev branch from cb9a8ec to 2111002 Compare May 22, 2017 21:11

Belphemur merged commit 578724f into Belphemur:dev May 25, 2017

Belphemur mentioned this pull request May 25, 2017

Update German #189

Closed

FireEmerald added a commit that referenced this pull request May 25, 2017

Translated English into German for PR #186.

2883cce

ToDo: French translation is missing for: (@Belphemur) - SettingsStrings.fr, notificationTooltip. - UpdateDownloadStrings, notSigned.

allcontributors bot mentioned this pull request Dec 18, 2021

docs: add ramon18 as a contributor for code #845

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some improvements and a feature #186

Some improvements and a feature #186

ramon18 commented May 22, 2017 •

edited

Loading

FireEmerald left a comment •

edited

Loading

FireEmerald May 22, 2017

FireEmerald May 22, 2017 •

edited

Loading

FireEmerald May 22, 2017 •

edited

Loading

FireEmerald May 22, 2017

FireEmerald May 22, 2017

FireEmerald May 22, 2017

FireEmerald May 22, 2017

FireEmerald May 22, 2017

FireEmerald May 22, 2017

ramon18 commented May 22, 2017 •

edited

Loading

Belphemur commented May 24, 2017 via email

Belphemur commented May 25, 2017

Belphemur commented Dec 18, 2021

allcontributors bot commented Dec 18, 2021

Some improvements and a feature #186

Some improvements and a feature #186

Conversation

ramon18 commented May 22, 2017 • edited Loading

FireEmerald left a comment • edited Loading

Choose a reason for hiding this comment

FireEmerald May 22, 2017

Choose a reason for hiding this comment

FireEmerald May 22, 2017 • edited Loading

Choose a reason for hiding this comment

FireEmerald May 22, 2017 • edited Loading

Choose a reason for hiding this comment

FireEmerald May 22, 2017

Choose a reason for hiding this comment

FireEmerald May 22, 2017

Choose a reason for hiding this comment

FireEmerald May 22, 2017

Choose a reason for hiding this comment

FireEmerald May 22, 2017

Choose a reason for hiding this comment

FireEmerald May 22, 2017

Choose a reason for hiding this comment

FireEmerald May 22, 2017

Choose a reason for hiding this comment

ramon18 commented May 22, 2017 • edited Loading

Belphemur commented May 24, 2017 via email

Belphemur commented May 25, 2017

Belphemur commented Dec 18, 2021

allcontributors bot commented Dec 18, 2021

ramon18 commented May 22, 2017 •

edited

Loading

FireEmerald left a comment •

edited

Loading

FireEmerald May 22, 2017 •

edited

Loading

FireEmerald May 22, 2017 •

edited

Loading

ramon18 commented May 22, 2017 •

edited

Loading